Skip to content.

Etria Lists

 

[quills-dev] [Collective-checkins] r34821 - Quills/branches/1.5

quills-dev at lists.etria.com quills-dev at lists.etria.com
Mon Dec 18 12:07:29 UTC 2006


Author: tim2p
Date: Mon Dec 18 12:07:28 2006
New Revision: 34821

Modified:
   Quills/branches/1.5/Weblog.py
Log:
Return (alphabetically) sorted keywords for more consistent ordering in the display of topics - as requested at <http://plone.org/products/quills/issues/74>. N.B. I wondered whether to commit this to the 1.5 *maintenance* branch as it subtley changes the return value of this method: from a dictionary with meaningful keys and non-meaningful values to a list of the keys.  I take the view that the original implementation was simply incorrect, and thus this was a bug.

Modified: Quills/branches/1.5/Weblog.py
==============================================================================
--- Quills/branches/1.5/Weblog.py	(original)
+++ Quills/branches/1.5/Weblog.py	Mon Dec 18 12:07:28 2006
@@ -282,7 +282,9 @@
         for entry in entries:
             for kw in entry.Subject:
                 keywords[kw] = None
-        return keywords
+        keys = keywords.keys()
+        keys.sort()
+        return keys
 
     # XXX: Fixup for removal of 'archive' folder
     security.declareProtected(perms.View, 'getArchives')

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Collective-checkins mailing list
Collective-checkins at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/collective-checkins



More information about the quills-dev mailing list