Etria Lists

Hi Clayton,

quills-dev at lists.etria.com wrote:
> Author: claytron
> Date: Tue Sep 18 05:09:16 2007
> New Revision: 49443
> 
> Modified:
>    quills.app/trunk/quills/app/archive.py
>    quills.app/trunk/quills/app/topic.py
>    quills.app/trunk/quills/app/weblogentrybrain.py
>    quills.core/trunk/quills/core/interfaces/topic.py
>    quills.core/trunk/quills/core/interfaces/weblogentry.py
> Log:
> fixing up the tests and fulfilling contracts
> 
>  * removed `self` from a couple interfaces
>  * added `getWeblogEntryContentObject` method to the quills.app.weblogentrybrain to satisfy interface
>  * implemented the `max` and `offset` for the `getEntries` methods to satisfy the interface
> 
> Modified: quills.app/trunk/quills/app/archive.py
> ==============================================================================
> --- quills.app/trunk/quills/app/archive.py	(original)
> +++ quills.app/trunk/quills/app/archive.py	Tue Sep 18 05:09:16 2007
> @@ -109,11 +109,13 @@
>          years = self._getEntryYears()
>          return [YearArchive(year).__of__(self) for year in years]
>  
> -    def getEntries(self):
> +    def getEntries(self, max=None, offset=0):

Seeing your checkin reminded me that I left the interfaces in a slightly
inconsistent state.  For methods that return sequences of IWeblogEntry
objects, I was trying to move to a signature looking like:

    def getEntries(self, maximum=None, offset=0):

The reason being that I discovered that `max' is actually a builtin
function in python which was getting masked by the name's use for local
variables.  That seemed like bad form, so I changed to `maximum'... but
obviously didn't get around to changing all of the interfaces.

Sorry!


Tim