Skip to content.

Etria Lists

 

[quills-dev] [Collective-checkins] r49443 - quills.app/trunk/quills/app quills.core/trunk/quills/core/interfaces

Clayton Parker clayton at sixfeetup.com
Wed Sep 19 13:52:14 UTC 2007



>>  * implemented the `max` and `offset` for the `getEntries` methods to satisfy the interface
>>
>> Modified: quills.app/trunk/quills/app/archive.py
>> ==============================================================================
>> --- quills.app/trunk/quills/app/archive.py	(original)
>> +++ quills.app/trunk/quills/app/archive.py	Tue Sep 18 05:09:16 2007
>> @@ -109,11 +109,13 @@
>>          years = self._getEntryYears()
>>          return [YearArchive(year).__of__(self) for year in years]
>>  
>> -    def getEntries(self):
>> +    def getEntries(self, max=None, offset=0):
> 
> Seeing your checkin reminded me that I left the interfaces in a slightly
> inconsistent state.  For methods that return sequences of IWeblogEntry
> objects, I was trying to move to a signature looking like:
> 
>     def getEntries(self, maximum=None, offset=0):
> 
> The reason being that I discovered that `max' is actually a builtin
> function in python which was getting masked by the name's use for local
> variables.  That seemed like bad form, so I changed to `maximum'... but
> obviously didn't get around to changing all of the interfaces.
> 
> Sorry!
> 

No worries.  I didn't know that was a builtin either :)  Interesting to
note that min is also a builtin that does the opposite.

I don't remember if it was you or Tom that put in those interface tests,
but that was a great idea!  New tool in my arsenal for sure.

claytron
-- 
S i x  F e e t  U p ,  I n c .  |  "Nowhere to go but open source"
Silicon Valley: +1 (650) 401-8579 x603
Midwest: +1 (317) 861-5948 x603
Toll-Free: 1-866-SIX-FEET
mailto:clayton at sixfeetup.com
http://www.sixfeetup.com  |  Zope/Plone Custom Development


More information about the quills-dev mailing list