Etria Lists

changed in r49857.

thanks for looking over my shoulder!

cheers,

tom

On 21.09.2007, at 14:35, Tim Hicks wrote:

> quills-dev at lists.etria.com wrote:
>> Author: tomster
>> Date: Fri Sep 21 12:25:37 2007
>> New Revision: 49845
>>
>> Modified:
>>    quills.app/trunk/quills/app/acquiringactions.py
>>    quills.app/trunk/quills/app/archive.py
>>    quills.app/trunk/quills/app/topic.py
>>    quills.core/trunk/quills/core/interfaces/archive.py
>>    quills.core/trunk/quills/core/interfaces/topic.py
>> Log:
>> changed signature to use `maxiumum` instead of `max` (which is a  
>> python builtin) as per issue 108
>>
>> Modified: quills.app/trunk/quills/app/acquiringactions.py
>> ===================================================================== 
>> =========
>> --- quills.app/trunk/quills/app/acquiringactions.py	(original)
>> +++ quills.app/trunk/quills/app/acquiringactions.py	Fri Sep 21  
>> 12:25:37 2007
>> @@ -33,7 +33,7 @@
>>          raise NotImplementedError
>>
>>      def listActionInfos(self, action_chain=None, object=None,  
>> check_visibility=1,
>> -                        check_permissions=1, check_condition=1,  
>> max=-1):
>> +                        check_permissions=1, check_condition=1,  
>> maximum=-1):
>>          """ List ActionInfo objects.
>>
>>          'action_chain' is a sequence of action 'paths' (e.g.  
>> 'object/view').
>> @@ -41,7 +41,7 @@
>>
>>          If 'object' is specified, object specific Actions are  
>> included.
>>
>> -        If 'max' is specified, only the first max Actions are  
>> returned.
>> +        If 'maximum' is specified, only the first maximum Actions  
>> are returned.
>>
>>          Permission -- Always available (not publishable)
>
> Tom,
>
> The change to listActionInfos is not right.  That method is just
> implementing an interface defined in the CMF, so it's not for us to
> change it.
>
> The rest looks good, though.
>
> Tim
>

Tom Lazar
http://tomster.org