Skip to content.

Etria Lists

 

[quills-dev] Workflow problems in Quills 1.6 (Bug #126)

Tim Hicks tim at sitefusion.co.uk
Thu May 22 21:05:40 UTC 2008


Jan Hackel wrote:
> As bug report #126 (http://plone.org/products/quills/issues/126)
> states, Quills 1.6 has problems with some workflows, for instance the
> one state workflow. As I need to use different workflows than the
> default ones I would like to so this fixed. However, I have some
> difficulties seeing how this could be done, as it's mostly "by
> design". Maybe someone one the list has some suggestions.
> 
> Here is what's the problem:
> 
> Quills makes some very specific assumptions about what "published" of
> an entry means: 1) being in workflow state "published" and more
> implicitly 2) having a slot "effective".
> 
> The first problem is easy to be fixed, one must simply remove the
> statement review_state = 'published' from the catalog query (e.g. in
> Product.Quills.Weblog.getEntries). Quills should not make such
> assumptions. In my opinion it is far better to leave visibility of
> blog entries to Plone workflow and sharing. If reference to
> "review_state" is needed, then the name of the actual published state
>  should be configurable on per blog basis. However, I think this is
> to much fuss. Is there anything speaking against the modification?

We already have this configurable-per-blog setup on QuillsEnabled.  See 
the getEntries method at 
<http://dev.plone.org/collective/browser/Products.QuillsEnabled/trunk/Products/QuillsEnabled/adapters/folder.py>. 
  The equivalent change should be made on Products.Quills (trunk), as 
well.  Can you do that?

As to th issue of whether we need to configure this at all, we had a 
short discussion about this on this list a few months ago.  Take a look 
in the archives for more details.

> For the second problem, I am not quite sure if this is not a bug in
> the one state workflow. Anyone knows more?

Ah, yeah, the one-state workflow issue seems a bit of a pain.  I'm not 
sure what the right thing to do is here.  Perhaps worth asking on 
product-developers whether the lack of an 'effective' datetime is a bug 
in the workflow.  If the answer comes back "no", then I'm not sure what 
to do.  Any ideas?


Tim


More information about the quills-dev mailing list